Platform detection on MinGW+Windows #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the xmake config script, there is a platform check performed when the build system is MinGW.
UnityDoorstop/xmake.lua
Lines 49 to 57 in 5607be4
When running on my Windows machine under MinGW, neither branch is being taken and the library produced has no valid entrypoint.
Here's what
xmake show
tells on my machine:The supplied fix fix for that changes the condition on line 54 to
is_arch("x64", "x86_64")
, as also suggested by xmake docs.