Import jumps on to comment line when there is a comment

[ckipp01]

Given the following code block, if you run scalafix it will cause the second import to jump up a line resulting in it being commented out.

import java.time.Period
// import this here
import java.time.Instant

object hello extends App {

  val x: Instant = Instant.now()
  val y: Period = Period.ZERO

}

It will become this:

import java.time.Period
// import this hereimport java.time.Instant

object hello extends App {

  val x: Instant = Instant.now()
  val y: Period = Period.ZERO

}

[NeQuissimus]

This is funny, I was literally trying to reproduce something like this from memory the other day but had no luck.
I have indeed encountered this before.
It is likely due to SortImport not working on comments at all.

PRs welcome, otherwise I will get around to it whenever I have some free time.

[ckipp01]

Sounds good! If I get a moment I'll take a look to see if it's something clear to me and easy to fix.

[He-Pin]

was fixed into

    // need implicit system for dilated    import context.system

[He-Pin]

@NeQuissimus
Try akka.actor.FSMTimingSpec

[He-Pin]

[He-Pin]

Change src/main/scala/fix/commented.scala to

/*
rule = SortImports
 SortImports.blocks = [
 "java",
 "scala",
 "*",
 "com.sun"
 ]
 */
import scala.util._ // foobar
import scala.collection._
import java.util.Map
import com.oracle.net._
import com.sun.awt._
import java.math.BigInteger

/**
 *  Bla
 */
object Bla {
  val foo = "Hello" // World

  //comment between 1
  import java.util.fucntion._
  //comment between 2
  import java.concurrent._
}

can produce this
@NeQuissimus

[He-Pin]

@NeQuissimus you can check out https://github.com/akka/akka/pull/28780 and run sortImports to reproduce.

[ckipp01]

Just have to clean this up locally and figure out a couple edge cases, but I've got a fix that I should be able to push up soon.

[He-Pin]

Very cool @ckipp01 , looking forward to your fix, thanks for sharing.

[ckipp01]

I more than likely won't get this fixed for a while. If anyone wants to work off what I had started, it's closed to being finished and the tests are there as well. My branch is here https://github.com/ckipp01/sort-imports/tree/comments