Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a host of the tool I want to be able to add any (several) language(s) used by my user group so that I can provide a useful tool. #109

Open
7 tasks
Tracked by #63
lisasund opened this issue Nov 11, 2020 · 5 comments
Assignees
Labels
Type: User story A feature/functionality request that is used in sprint planning
Milestone

Comments

@lisasund
Copy link
Contributor

lisasund commented Nov 11, 2020

User story

As a host of the tool I want to be able to add any (several) language(s) used by my user group so that I can provide a useful tool.

Acceptance criteria

  • It is possible to add more than one language translatation in language file
  • It is possible to choose a default language

Sprint Ready Checklist

    • Acceptance criteria defined
    • Team understands acceptance criteria
    • Team has defined solution / steps to satisfy acceptance criteria
    • Acceptance criteria is verifiable / testable
    • External / 3rd Party dependencies identified
@lisasund lisasund added the Type: User story A feature/functionality request that is used in sprint planning label Nov 11, 2020
@lisasund
Copy link
Contributor Author

lisasund commented Dec 2, 2020

Also translate "aria-label" othervise seems fine!

@lisasund lisasund added this to the Sprint 9 milestone Dec 2, 2020
@lisasund
Copy link
Contributor Author

lisasund commented Dec 8, 2020

@idali0226

When translating to English I found that the following changed: when searching for a coordinate the text over the result is "2 home.dinplats", when it actually should be "1 träff samt "Din plats"" or "{number of hits} träffar samt "Din plats"".

i18n-development branch
image

current ui
image

@lisasund
Copy link
Contributor Author

lisasund commented Dec 8, 2020

@idali0226 I also would need help to add "Din plats" to translation JSON files, both the text visible in list view and that in Detailed vie (the card title)

@lisasund
Copy link
Contributor Author

lisasund commented Dec 9, 2020

The number of hits are now correct when searching for a coordinate, but when you click on the coordinate switch after searching the text changes, see pictures

After searching for a coordinate
image

Same result, just changed the coordinate switch:
image

@idali0226
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: User story A feature/functionality request that is used in sprint planning
Projects
None yet
Development

No branches or pull requests

2 participants