Skip to content

Commit

Permalink
fix: register MediaView for angular & vue
Browse files Browse the repository at this point in the history
  • Loading branch information
triniwiz committed Oct 6, 2021
1 parent 70badaf commit 48f12ee
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 5 deletions.
6 changes: 4 additions & 2 deletions packages/firebase-admob/angular/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ import { registerElement } from '@nativescript/angular';

import { BannerAdDirective } from './banner-ad-directive';
import { NativeAdViewDirective } from './native-ad-view-directive';
import { MediaViewDirective } from './media-view-directive';

@NgModule({
declarations: [BannerAdDirective, NativeAdViewDirective],
exports: [BannerAdDirective, NativeAdViewDirective],
declarations: [BannerAdDirective, NativeAdViewDirective, MediaViewDirective],
exports: [BannerAdDirective, NativeAdViewDirective, MediaViewDirective],
})
// @ts-ignore
export class AdmobModule {}

registerElement('NativeAdView', () => require('@nativescript/firebase-admob').NativeAdView);
registerElement('BannerAd', () => require('@nativescript/firebase-admob').BannerAd);
registerElement('MediaView', () => require('@nativescript/firebase-admob').MediaView);
6 changes: 6 additions & 0 deletions packages/firebase-admob/angular/media-view-directive.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { Directive } from '@angular/core';

@Directive({
selector: 'MediaView',
})
export class MediaViewDirective {}
2 changes: 1 addition & 1 deletion packages/firebase-admob/nativead/index.android.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export { VideoStatus, AdEventType, AdChoicesPlacement, MediaAspectRatio };
const NATIVE_AD_LOADED_EVENT = 'adNativeAdLoaded';
const AD_MANAGER_AD_VIEW_LOADED_EVENT = 'adManagerAdViewLoaded';

@CSSType('NativeAdView')

export class NativeAdView extends NativeAdViewBase implements AddChildFromBuilder {
#native: com.google.android.gms.ads.nativead.NativeAdView;
#children: View[] = []
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase-admob/nativead/index.ios.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { AdChoicesPlacement, IMediaContent, IMuteThisAdReason, INativeAd, INativ

export { VideoStatus, AdEventType, AdChoicesPlacement, MediaAspectRatio };
declare const AdLoaderAdType;
@CSSType('NativeAdView')

export class NativeAdView extends NativeAdViewBase implements AddChildFromBuilder {
#native: GADNativeAdView;
#children: View[] = [];
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase-admob/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nativescript/firebase-admob",
"version": "1.0.0-alpha.0",
"version": "1.0.0-alpha.1",
"description": "NativeScript Firebase - Admob",
"main": "index",
"typings": "index.d.ts",
Expand Down
1 change: 1 addition & 0 deletions packages/firebase-admob/vue/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ export default {
install(Vue) {
Vue.registerElement('NativeAdView', () => require('../').NativeAdView);
Vue.registerElement('BannerAd', () => require('../').BannerAd);
Vue.registerElement('MediaView', () => require('../').MediaView);
},
};

0 comments on commit 48f12ee

Please sign in to comment.