EKIR-206 Add rules for missing Bisac subjects #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natlibfi-kaisa
requested review from
natlibfi-ptalosel and
NatLibFi-JoonaKupe
natlibfi-ptalosel
approved these changes
Jan 16, 2025
NatLibFi-JoonaKupe
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New BISAC subject to genre assignment rules for ones that were missing.
Motivation and Context
These rules only deal with the subjects that were missing for adult fiction. There are still Juvenile and YA subjects missing rules but we'll deal with them in the near future.
How Has This Been Tested?
Unit tests
Checklist