Reorganized the usage of the main element in vocabulary search page

[joelit]

Reasons for creating this PR

Vocabulary search page was mis-using the main element, causing there to be a duplicate structure:

This could be further refactored by using the values of the pageType variable as the CSS classes for different page styles. PageTypes are:

• vocab-home
• vocab-search
• global-search
• feedback
• error
• about
• concept
• landing

This PR makes the following changes:

• vocabpage -> vocab-home
• searchpage -> vocab-search
• termpage -> concept
• frontpage -> landing
• feedbackpage -> feedback
• infopage -> about
• (searchpage-multi-vocab -> global-search implemented in PR Global Search twig-template #1758)

Description of the changes in this PR

• Brought the structure of vocabulary search page more in line with vocabulary front page and concept page
• Removed references to global search page for now

Known problems or uncertainties in this PR

None

Checklist

• phpUnit tests pass locally with my changes
• I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
• The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
• The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.94%. Comparing base (53aa787) to head (e689a69).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #1756   +/-   ##
=========================================
  Coverage     70.94%   70.94%           
  Complexity     1650     1650           
=========================================
  Files            33       33           
  Lines          4330     4330           
=========================================
  Hits           3072     3072           
  Misses         1258     1258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joelit]

Ok, this contains now the major refactoring of the page type classes. They are all checked against the visual spec. Now, all that remains is to resolve the inevitable conflcts with the responsive layout commits.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[osma]

LGTM. It's likely that something broke but I couldn't find it :)