Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spanish translation #321

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added spanish translation #321

wants to merge 2 commits into from

Conversation

MxtAppz
Copy link

@MxtAppz MxtAppz commented Oct 1, 2023

๐Ÿ“ Description of the pull request, what, why and where

This PR has added the Spanish translation

โœ… How to test

-Set the language to Spanish

๐Ÿ“น Demo

@Nain57 Nain57 self-requested a review October 1, 2023 17:17
Copy link
Owner

@Nain57 Nain57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thanks for your contribution.

Quick review:

  • You don't need to recreate files that does not contains a string to be translated (colors.xml, dimens.xml ...). Basically, you should only have a strings.xml file in the values-es folders (beside some exceptions like event_default_config)
  • Be carefull with the indentation, it seems wrong in some strings.xml files

I will look more in details this week if i can find some time, but you can already fix those issues.
Thank you again !

@c-sanchez
Copy link

๐Ÿ˜ฎ Coincidentally I'm finishing my translation in Spanish, I just needed to translate the last tutorial ๐Ÿ˜…

@MxtAppz
Copy link
Author

MxtAppz commented Oct 1, 2023

Hi and thanks for your contribution.

Quick review:

* You don't need to recreate files that does not contains a string to be translated (colors.xml, dimens.xml ...). Basically, you should only have a strings.xml file in the values-es folders (beside some exceptions like event_default_config)

* Be carefull with the indentation, it seems wrong in some strings.xml files

I will look more in details this week if i can find some time, but you can already fix those issues. Thank you again !

Do the indentation and line breaks matter? I thought this was set by \n and \t. Sorry about that :-( .

Copy link
Owner

@Nain57 Nain57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i had a rough week and didn't have the time to check your PR.

  • I was talking about the indentation of the elements, always start them after 4 spaces. Inside the element, indentation doesn't matter, you are right.

  • It still doesn't compile, the tutorial strings file seems incomplete.

  • You have removed all the unecessary files, but you have also removed event_default_config.xml which contains the default names with events, conditions and actions, you might want to keep it 44da88d#diff-03800a52bebcbb58e5347dc5798b8a8c14cc2dbcbfd527a49a5de1fd84bacfd9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants