-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added spanish translation #321
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi and thanks for your contribution.
Quick review:
- You don't need to recreate files that does not contains a string to be translated (colors.xml, dimens.xml ...). Basically, you should only have a strings.xml file in the values-es folders (beside some exceptions like event_default_config)
- Be carefull with the indentation, it seems wrong in some strings.xml files
I will look more in details this week if i can find some time, but you can already fix those issues.
Thank you again !
๐ฎ Coincidentally I'm finishing my translation in Spanish, I just needed to translate the last tutorial ๐ |
Do the indentation and line breaks matter? I thought this was set by \n and \t. Sorry about that :-( . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, i had a rough week and didn't have the time to check your PR.
-
I was talking about the indentation of the elements, always start them after 4 spaces. Inside the element, indentation doesn't matter, you are right.
-
It still doesn't compile, the tutorial strings file seems incomplete.
-
You have removed all the unecessary files, but you have also removed event_default_config.xml which contains the default names with events, conditions and actions, you might want to keep it 44da88d#diff-03800a52bebcbb58e5347dc5798b8a8c14cc2dbcbfd527a49a5de1fd84bacfd9
๐ Description of the pull request, what, why and where
This PR has added the Spanish translation
โ How to test
-Set the language to Spanish
๐น Demo