Adopt JSONUtils.concatenateJsonStrings for concatenating JSON strings
#11549
+71
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
# Conflicts: # sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuJsonReadCommon.scala # sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuJsonToStructs.scala
# Conflicts: # sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuJsonReadCommon.scala
revans2
reviewed
Oct 1, 2024
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
ttnghia
commented
Oct 1, 2024
|
|
||
| @allow_non_gpu(*non_utc_allow) | ||
| def test_from_json_input_wrapped_in_whitespaces(): | ||
| json_string_gen = StringGen(r'[ \r\n\t]{0,5}({"key":( |\r|\n|\t|)"[A-z]{0,5}"}|null|invalid|)[ \r\n\t]{0,5}') |
There was a problem hiding this comment.
Will generate text that is either:
- '{"key":( |\r|\n|\t|)"[A-z]{0,5}"}'
- 'null'
- 'invalid'
- Empty string
And each of these strings is surrounded by whitespace chars [ \r\n\t]{0,5}.
There was a problem hiding this comment.
Can be tested at https://onlinestringtools.com/generate-string-from-regex
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
revans2
previously approved these changes
Oct 7, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuJsonReadCommon.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuJsonToStructs.scala
Show resolved
Hide resolved
|
build |
|
build |
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
build |
revans2
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adopts the newly implemented
JSONUtils.concatenateJsonStringsfrom spark-rapids-jni for concatenating JSON strings into one single string for reading using cudf's JSON reader.Depends on:
concat_jsonto join JSON strings given by strings column spark-rapids-jni#2457.This will also closes #10922.