Rework Maven Source Plugin Skip #11246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerashegalov
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
jlowe
previously approved these changes
Jul 24, 2024
|
build |
razajafri
reviewed
Jul 24, 2024
aggregator/pom.xml
Outdated
| @@ -44,6 +44,7 @@ | |||
| <rapids.default.jar.phase>initialize</rapids.default.jar.phase> | |||
| <!-- Maven to register attached artifact , which we later replace --> | |||
| <rapids.shim.jar.phase>initialize</rapids.shim.jar.phase> | |||
| <rapdis.source.jar.phase>none</rapdis.source.jar.phase> | |||
razajafri
reviewed
Jul 24, 2024
dist/pom.xml
Outdated
| @@ -46,6 +46,7 @@ | |||
| <dist.jar.pom.url>jar:file:${dist.jar.name}!/META-INF/maven/${project.groupId}/${project.artifactId}/pom.xml</dist.jar.pom.url> | |||
| <rapids.default.jar.phase>none</rapids.default.jar.phase> | |||
| <rapids.jni.unpack.skip>false</rapids.jni.unpack.skip> | |||
| <rapdis.source.jar.phase>none</rapdis.source.jar.phase> | |||
There was a problem hiding this comment.
same comment as above and all the other places in this PR
Signed-off-by: Gera Shegalov <gera@apache.org>
|
build |
1 similar comment
|
build |
pxLi
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11245
rapids.*.jar.phase