Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unused vars from the version-def CI script #11236

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Remove the unused vars from the version-def CI script #11236

merged 2 commits into from
Jul 24, 2024

Conversation

NvTimLiu
Copy link
Collaborator

@NvTimLiu NvTimLiu commented Jul 22, 2024 •
edited
Loading

To fix: #11223

The definition of CUDF_VER=24.08.0-SNAPSHOT is unreferenced/unused, because we'd changed to depend on the spark-rapids-jni jar instead.

Need to remove unreferenced CUDF_VER=xxx in the CI script: https://github.com/NVIDIA/spark-rapids/blob/branch-24.08/jenkins/version-def.sh#L29

@NvTimLiu
Remove the unused var CUDF_VER from the CI script
2d067b0 
Signed-off-by: Tim Liu <timl@nvidia.com>
@NvTimLiu NvTimLiu added the build Related to CI / CD or cleanly building label Jul 22, 2024
@NvTimLiu NvTimLiu self-assigned this Jul 22, 2024
@NvTimLiu
Copy link
Collaborator Author

build

jlowe
jlowe reviewed Jul 22, 2024
View reviewed changes
jenkins/version-def.sh
@@ -27,7 +27,6 @@ done
IFS=$PRE_IFS


CUDF_VER=${CUDF_VER:-"24.08.0-SNAPSHOT"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is echo'd below, need to remove that as well.

@NvTimLiu
Update for the review comment
8e53168 
Signed-off-by: Tim Liu <timl@nvidia.com>
@NvTimLiu
Copy link
Collaborator Author

build

@gerashegalov gerashegalov changed the title Remove the unused var CUDF_VER from the CI script Remove the unused vars from the version-def CI script Jul 23, 2024
@NvTimLiu
Copy link
Collaborator Author

CI failed with ConnectionRefusedError

[2024-07-23T01:50:04.593Z] >           self.socket.connect((self.java_address, self.java_port))
[2024-07-23T01:50:04.593Z] E           ConnectionRefusedError: [Errno 111] Connection refused
[2024-07-23T01:50:04.593Z] /home/jenkins/agent/workspace/jenkins-rapids_premerge-github-9797-ci-2/.download/spark-3.2.0-bin-hadoop3.2/python/lib/py4j-0.10.9.2-src.zip/py4j/clientserver.py:402: ConnectionRefusedError

@NvTimLiu
Copy link
Collaborator Author

build

@NvTimLiu
Copy link
Collaborator Author

build

1 similar comment
@NvTimLiu
Copy link
Collaborator Author

build

@NvTimLiu NvTimLiu merged commit 8bc4712 into NVIDIA:branch-24.08 Jul 24, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@gerashegalov gerashegalov gerashegalov approved these changes

@pxLi pxLi pxLi approved these changes

@razajafri razajafri Awaiting requested review from razajafri

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@yinqingh yinqingh Awaiting requested review from yinqingh

@YanxuanLiu YanxuanLiu Awaiting requested review from YanxuanLiu

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

Assignees

@NvTimLiu NvTimLiu

Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Remove unreferenced CUDF_VER=xxx in the CI script
4 participants
@NvTimLiu @jlowe @gerashegalov @pxLi