Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache dependencies for scala 2.13 [skip ci] #11231

Merged
merged 11 commits into from
Jul 23, 2024
Merged

Cache dependencies for scala 2.13 [skip ci] #11231

merged 11 commits into from
Jul 23, 2024

Conversation

YanxuanLiu
Copy link
Collaborator

Fix #11199

  1. changed set-scala213-versions to cache-dependencies-scala213, and added caching steps to this stage.
  2. add .github/workflows/mvn-verify-check/populate-daily-cache.sh for caching dependencies for both scala 2.12 and 2.13.

@YanxuanLiu
add cache dependencies step for scala 213
0679211 
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
@YanxuanLiu
add populate script
4740edb 
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
@YanxuanLiu
move yml
44368a1 
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
@YanxuanLiu YanxuanLiu added the build Related to CI / CD or cleanly building label Jul 19, 2024
@YanxuanLiu YanxuanLiu self-assigned this Jul 19, 2024
@YanxuanLiu YanxuanLiu requested review from pxLi and yinqingh July 19, 2024 06:52
@YanxuanLiu
Copy link
Collaborator Author

test build: https://github.com/YanxuanLiu/spark-rapids/actions/runs/10003551543

pxLi
pxLi requested changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@pxLi pxLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many issues, please focus more on our objectives of setup the cache steps rather than merely passing the checks. Thank you.

.github/workflows/mvn-verify-check/populate-daily-cache.sh Outdated Show resolved Hide resolved
@YanxuanLiu
Copy link
Collaborator Author

YanxuanLiu commented Jul 22, 2024 •
edited
Loading

There are many issues, please focus more on our objectives of setup the cache steps rather than merely passing the checks. Thank you.

Fixed the issues of parameters from previous PR #10994.

I set an env var SCALA_VER in github workflow, and the shell script will use appropriate pom file and buildvers according to the var value.

@YanxuanLiu
hardcode buildvers
8d39db8 
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
@YanxuanLiu YanxuanLiu marked this pull request as ready for review July 22, 2024 10:59
pxLi
pxLi previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@pxLi pxLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets keep monitoring for a while after merge thanks

@gerashegalov gerashegalov changed the title Cache dependencies for scala 2.13 Cache dependencies for scala 2.13 [skip ci] Jul 23, 2024
gerashegalov
gerashegalov previously approved these changes Jul 23, 2024
View reviewed changes
.github/workflows/mvn-verify-check.yml Outdated Show resolved Hide resolved
.github/workflows/mvn-verify-check.yml Outdated Show resolved Hide resolved
pxLi and others added 2 commits July 23, 2024 08:39
@pxLi @gerashegalov
Update .github/workflows/mvn-verify-check.yml for extra new line
19c1da5 
Co-authored-by: Gera Shegalov <gshegalov@nvidia.com>
@pxLi @gerashegalov
Update .github/workflows/mvn-verify-check.yml for extra new line
b19a8f2 
Co-authored-by: Gera Shegalov <gshegalov@nvidia.com>
@pxLi pxLi dismissed stale reviews from gerashegalov and themself via b19a8f2 July 23, 2024 00:40
@pxLi @gerashegalov
Update .github/workflows/mvn-verify-check.yml to differentiate the ca…
be58393 
…che key cleart

Co-authored-by: Gera Shegalov <gshegalov@nvidia.com>
pxLi
pxLi previously approved these changes Jul 23, 2024
View reviewed changes
@pxLi pxLi closed this Jul 23, 2024
@pxLi pxLi reopened this Jul 23, 2024
@YanxuanLiu
fix nit
0296784 
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
@pxLi
Copy link
Collaborator

pxLi commented Jul 23, 2024

build

@pxLi pxLi merged commit 6d65548 into NVIDIA:branch-24.08 Jul 23, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxLi pxLi pxLi approved these changes

@gerashegalov gerashegalov gerashegalov left review comments

@yinqingh yinqingh Awaiting requested review from yinqingh

@jlowe jlowe Awaiting requested review from jlowe jlowe is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

Assignees

@YanxuanLiu YanxuanLiu

Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle cache for scala2.13 build dependencies
3 participants
@YanxuanLiu @pxLi @gerashegalov