Rework on substring index #11149
Merged
Rework on substring index #11149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fejiang <fejiang@nvidia.com>
Signed-off-by: fejiang <fejiang@nvidia.com>
Signed-off-by: fejiang <fejiang@nvidia.com>
Signed-off-by: fejiang <fejiang@nvidia.com>
Signed-off-by: fejiang <fejiang@nvidia.com>
|
Depends on NVIDIA/spark-rapids-jni#2205 |
Signed-off-by: fejiang <fejiang@nvidia.com>
Signed-off-by: fejiang <fejiang@nvidia.com>
Feng-Jiang28
changed the title
Signed-off-by: fejiang <fejiang@nvidia.com>
Signed-off-by: fejiang <fejiang@nvidia.com>
thirtiseven
reviewed
Jul 16, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
tests/src/test/spark330/scala/org/apache/spark/sql/rapids/utils/RapidsTestSettings.scala
Outdated
Show resolved
Hide resolved
...rc/test/spark330/scala/org/apache/spark/sql/rapids/suites/RapidsStringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: fejiang <fejiang@nvidia.com>
|
build |
Signed-off-by: fejiang <fejiang@nvidia.com>
|
build |
…into reworkonsubstringindex
Signed-off-by: fejiang <fejiang@nvidia.com>
Signed-off-by: fejiang <fejiang@nvidia.com>
|
build |
1 similar comment
|
build |
|
build |
thirtiseven
reviewed
Jul 23, 2024
...rc/test/spark330/scala/org/apache/spark/sql/rapids/suites/RapidsStringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: fejiang <fejiang@nvidia.com>
thirtiseven
reviewed
Jul 23, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: fejiang <fejiang@nvidia.com>
|
build |
revans2
previously approved these changes
Jul 23, 2024
jlowe
reviewed
Jul 23, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Show resolved
Hide resolved
Signed-off-by: fejiang <fejiang@nvidia.com>
|
build |
1 similar comment
|
build |
|
build |
jlowe
reviewed
Jul 24, 2024
There was a problem hiding this comment.
As I mentioned in my comment, docs need to be regenerated. Premerge checks are failing because of this. You can run mvn verify -DskipTests to regenerate the docs and then commit the changes.
[2024-07-24T13:11:36.608Z] found modified files during mvn verify:
[2024-07-24T13:11:36.609Z] M docs/supported_ops.md
Signed-off-by: fejiang <fejiang@nvidia.com>
jlowe
approved these changes
Jul 24, 2024
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on NVIDIA/spark-rapids-jni#2205
This PR is for closing issue #8750, by replace the regex implementation underneath with
cudf::strings::slice_strings()withcudf::strings::find()/rfind(), new implementation achieved 12X speed up comparing to the old version NVIDIA/spark-rapids-jni#2205 (comment)