Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[BUG]: Omegaconf missing from install for stormcast #172

Closed
NickGeneva opened this issue Dec 20, 2024 · 3 comments
Closed

🐛[BUG]: Omegaconf missing from install for stormcast #172

NickGeneva opened this issue Dec 20, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@NickGeneva
Copy link
Collaborator

Version

0.5.0a

On which installation method(s) does this occur?

Source

Describe the issue

Do we need a storm cast specific install, remove the need for omega conf or put it part of core install?

@NickGeneva NickGeneva added the bug Something isn't working label Dec 20, 2024
@pzharrington
Copy link
Collaborator

@NickGeneva For my own understanding, did this get through CI bc we run CI with the modulus container (which has omegaconf?)

@NickGeneva
Copy link
Collaborator Author

Yep exactly!

@pzharrington
Copy link
Collaborator

pzharrington commented Dec 20, 2024

Ok. Are you opposed to just adding omegaconf as a core dependency for now? Alternately we could swap the StormCast NGC package loading to json, which would require updating the public NGC package to use a json instead of yaml to store the model config -- maybe we wait until Dallas is back to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants