E2E tests were added #282
Merged
E2E tests were added #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glowkey
reviewed
Mar 13, 2024
rohit-arora-dev
previously approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Thanks @nvvfedorov for addressing the review comments.
/LGTM if @glowkey is ok with his testing.
glowkey
previously approved these changes
Mar 13, 2024
Signed-off-by: Vadym Fedorov <vfedorov@nvidia.com>
nvvfedorov
dismissed stale reviews from glowkey and rohit-arora-dev
via
b6cd780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end-to-tests required to maintain confidence that the dcgm-exporter works as expected correctly
after the changes. The tests aim to reproduce a typical deployment scenario on the K8S environment and tests
how do the following components work together on the K8S environment: