make kubelet pod-resources socket directory configurable #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is associated with issue #192 |
|
@zclyne , Please add a description with a use case to justify the change. |
Signed-off-by: Yifan Zhang <yzhang2343@bloomberg.net>
Signed-off-by: Vadym Fedorov <vfedorov@nvidia.com>
nvvfedorov
force-pushed
the
yifan/kubelet-socket-dir
branch
from
08ca978 to
05eff12
Compare
rohit-arora-dev
approved these changes
Mar 19, 2024
Sorry I missed your message for so long. The use case is that we customized our kubelet configuration so that the socket file is not exposed in the default directory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a new command-line parameter, "pod-resources-kubelet-socket," and a new environment variable, "DCGM_POD_RESOURCES_KUBELET_SOCKET." This will help specify a custom socket path when we mount the socket in the docker container.