Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding AFQMC tutorial #1844

Merged
merged 122 commits into from
Aug 21, 2024
Merged

Adding AFQMC tutorial #1844

merged 122 commits into from
Aug 21, 2024

Conversation

zohimchandani
Copy link
Collaborator

No description provided.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 21, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@zohimchandani zohimchandani self-assigned this Jun 21, 2024
@zohimchandani
Copy link
Collaborator Author

zohimchandani commented Jun 21, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@zohimchandani
Copy link
Collaborator Author

zohimchandani commented Jun 22, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis sacpis self-requested a review July 17, 2024 21:43
@sacpis
Copy link
Collaborator

sacpis commented Jul 18, 2024

! [remote rejected] HEAD -> zohimchandani/main (permission denied)
error: failed to push some refs to 'https://github.com/zohimchandani/cuda-quantum.git'

bmhowe23
bmhowe23 reviewed Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some continued comments about the spelling allow list....

.github/workflows/config/spelling_allowlist.txt Outdated Show resolved Hide resolved
.github/workflows/config/spelling_allowlist.txt Outdated Show resolved Hide resolved
.github/workflows/config/spelling_allowlist.txt Outdated Show resolved Hide resolved
.github/workflows/config/spelling_allowlist.txt Outdated Show resolved Hide resolved
.github/workflows/config/spelling_allowlist.txt Outdated Show resolved Hide resolved
.github/workflows/config/spelling_allowlist.txt Outdated Show resolved Hide resolved
.github/workflows/config/spelling_allowlist.txt Outdated Show resolved Hide resolved
.github/workflows/config/spelling_allowlist.txt Outdated Show resolved Hide resolved
.github/workflows/config/spelling_allowlist.txt Outdated Show resolved Hide resolved
.github/workflows/config/spelling_allowlist.txt Outdated Show resolved Hide resolved
@sacpis
Copy link
Collaborator

sacpis commented Jul 18, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis sacpis enabled auto-merge (squash) July 18, 2024 18:12
@sacpis
Copy link
Collaborator

sacpis commented Jul 19, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

1 similar comment
@sacpis
Copy link
Collaborator

sacpis commented Jul 19, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis
Copy link
Collaborator

sacpis commented Aug 20, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
@cuda-quantum-bot
Docs preview for PR #1844.
2641888
bmhowe23
bmhowe23 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor nit about the h5py versioning specification.

@sacpis
Copy link
Collaborator

sacpis commented Aug 20, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis
Copy link
Collaborator

sacpis commented Aug 20, 2024

Thank you @bmhowe23 for all your help here.

@sacpis
Copy link
Collaborator

sacpis commented Aug 20, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
@cuda-quantum-bot
Docs preview for PR #1844.
0cbeba5
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
@cuda-quantum-bot
Docs preview for PR #1844.
be5eca6
@sacpis
Copy link
Collaborator

sacpis commented Aug 21, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis
Copy link
Collaborator

sacpis commented Aug 21, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis
Copy link
Collaborator

sacpis commented Aug 21, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis
Copy link
Collaborator

sacpis commented Aug 21, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis sacpis merged commit 6489e8a into NVIDIA:main Aug 21, 2024
129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
@bettinaheim bettinaheim added the documentation Improvements or additions to documentation label Nov 19, 2024
@bettinaheim bettinaheim added this to the release 0.9.0 milestone Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sacpis sacpis sacpis approved these changes

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@bettinaheim bettinaheim Awaiting requested review from bettinaheim bettinaheim is a code owner

@amccaskey amccaskey Awaiting requested review from amccaskey

Assignees

@zohimchandani zohimchandani

@bmhowe23 bmhowe23

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
release 0.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zohimchandani @sacpis @bmhowe23 @bettinaheim