New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify python stack #1077

Merged

khalatepradnya merged 49 commits into NVIDIA:experimental/python from khalatepradnya:unify-python-stack

Feb 5, 2024

Collaborator

khalatepradnya commented Jan 9, 2024 •

edited

Loading

Description

This PR attempts to get a working docker image and Python wheels file for the experimental Python features.

Some tests are skipped and annotated with SKIP_TEST comment; fixes for which will be handled in separate PR.
New feature of remote simulation is not (yet) available in Python
Python wheel skipped for arm64 platform

khalatepradnya self-assigned this

khalatepradnya force-pushed the unify-python-stack branch from d3091c2 to 55f43e9 Compare

January 9, 2024 23:35

amccaskey reviewed

View reviewed changes

runtime/cudaq/platform/default/rest/CMakeLists.txt Outdated Show resolved Hide resolved

amccaskey reviewed

View reviewed changes

python/tests/unittests/test_kernel_builder.py Outdated Show resolved Hide resolved

Collaborator Author

khalatepradnya commented Jan 11, 2024 •

edited by github-actions bot

Loading

/ok to test

Command Bot: Processing...

khalatepradnya force-pushed the unify-python-stack branch from ce52024 to 242adae Compare

January 11, 2024 05:58

Collaborator Author

khalatepradnya commented Jan 11, 2024 •

edited by github-actions bot

Loading

/ok to test

Command Bot: Processing...

khalatepradnya force-pushed the unify-python-stack branch from 3b2cb31 to ecb272e Compare

January 11, 2024 21:59

khalatepradnya marked this pull request as ready for review

January 12, 2024 00:01

khalatepradnya requested review from bettinaheim and bmhowe23 as code owners

January 12, 2024 00:01

Collaborator Author

khalatepradnya commented Jan 12, 2024

Unable to get CI to work due to 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit..

Collaborator Author

khalatepradnya commented Jan 12, 2024 •

edited by github-actions bot

Loading

/ok to test

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

1ef97f8

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

3937d29

khalatepradnya force-pushed the unify-python-stack branch 2 times, most recently from e8eee6a to a14cd46 Compare

January 12, 2024 18:43

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

c4a6458

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

784bd03

Collaborator Author

khalatepradnya commented Jan 13, 2024 •

edited by github-actions bot

Loading

/ok to test

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

5db978d

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

0f43109

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

b58747b

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

41d8394

khalatepradnya force-pushed the unify-python-stack branch from e1ab08d to 3456469 Compare

January 16, 2024 05:24

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

khalatepradnya force-pushed the unify-python-stack branch from 485dab5 to 6604a67 Compare

January 16, 2024 18:34

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

0db8b44

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

Collaborator Author

khalatepradnya commented Jan 17, 2024 •

edited by github-actions bot

Loading

/ok to test

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

575ddf7


          * Fix for cudaq.chemistry

c635d9f

Co-authored-by: Alex McCaskey <amccaskey@nvidia.com>

khalatepradnya linked an issue

that may be closed by this pull request

[experimental/python] Improvements, gaps and fixes: Part#1 #1157

Closed

19 tasks

khalatepradnya removed a link to an issue

[experimental/python] Improvements, gaps and fixes: Part#1 #1157

Closed

19 tasks

khalatepradnya added 2 commits

February 2, 2024 10:46


          * Spellcheck fixes

63303f7


          * Removing commented out lines of code from

33df69c

  'double_excitation_gate_opt()' to satisfy spellchecker requirements.

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

7b9e7e5


          * Debug / Experiment - Removed the workaround for remote multi qpu

2998f6c

in 'jitAndCreateArgs()' to see if it affects the failure(s) seen on
CI pipeline (not reproducible locally).

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

cb10de0

khalatepradnya and others added 2 commits

February 2, 2024 14:03


          Revert "* Debug / Experiment - Removed the workaround for remote mult…

3ad8e55

…i qpu"

This reverts commit 2998f6c.


          * Making JIT execution classes thread safe

a610481

Co-authored-by: Ben Howe <bhowe@nvidia.com>

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

9c3ab06


          * This commit reverts the following 3 commits pertaining to enabling the

d44c081

  'remote' backend, its corresponding tests and adding of thread safe
code.
* Establish a baseline.

Revert "* Partial fix for 'remote' backend"

This reverts commit fbc07dd.

Revert "* Workaround for remote multi QPU implementation"

This reverts commit 2439890.

Revert "* Making JIT execution classes thread safe"

This reverts commit a610481.

khalatepradnya enabled auto-merge (squash)

February 3, 2024 00:13

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

9cc0b66

Collaborator

amccaskey commented Feb 3, 2024

We have FileCheck tests in both the compiler and mlir folder. We should probably merge these two together under one ctest target and in one folder.

Collaborator Author

khalatepradnya commented Feb 4, 2024 •

edited

Loading

We have FileCheck tests in both the compiler and mlir folder. We should probably merge these two together under one ctest target and in one folder.

Sure, I had them merged into 'mlir' but, reverted to keep existing functionality v/s new functionality tests - perhaps not necessary. I will club them back into one directory.
Fixed in 43273e6

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

b1d7ccb


          * Fix for [RFC] : Not sure why some 'eager' tests fail if run with th…

5764c0c

…e whole suite of tests

Co-authored-by: Alex McCaskey <amccaskey@nvidia.com>

khalatepradnya force-pushed the unify-python-stack branch from 370d44c to 5764c0c Compare

February 4, 2024 04:26


          * Consolidate Python tests under 'compiler' and 'mlir' under 'mlir'

43273e6

  directory.
* Python wheels stage update - we want to skip 'remote' tests until they
  are enabled but, '--ignore' has no effect, hence running individual
sub-directory.

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

55993c2


          Merge branch 'experimental/python' into unify-python-stack

4ae9302

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

0c4cdba

khalatepradnya requested a review from amccaskey

February 4, 2024 06:27

github-actions bot pushed a commit that referenced this pull request


          Docs preview for PR #1077.

662f2e2

amccaskey approved these changes

View reviewed changes

Collaborator

amccaskey left a comment

+1

khalatepradnya merged commit c5862a2 into NVIDIA:experimental/python

108 checks passed

github-actions bot locked and limited conversation to collaborators

khalatepradnya deleted the unify-python-stack branch

February 5, 2024 17:12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

amccaskey amccaskey approved these changes

bettinaheim Awaiting requested review from bettinaheim

bmhowe23 Awaiting requested review from bmhowe23

anthony-santana Awaiting requested review from anthony-santana

1tnguyen Awaiting requested review from 1tnguyen

schweitzpgi Awaiting requested review from schweitzpgi

Labels

None yet