Fix cuDNN sliding window size #1212
Merged
+5
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adjusts the sliding window size in
FusedAttention
(cuDNN attention) so it's consistent with our support inFlashAttention
andUnfusedDotProductAttention
.cuDNN supports sliding window
(i - window_size_left, i]
, exclusive of thei -window_size_left
element. By passingwindow_size_left + 1
to cuDNN, we achieve the same effect as the[i - window_size_left, i]
support.This PR also reduces the window size in our unit tests so any numerical differences between backends will be easier to notice.
Fixes #1197
Type of change
Changes
Please list the changes introduced in this PR:
window_size
passed to cuDNNChecklist: