Fix autocast deprecation warning. #1167
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/te-ci pytorch |
timmoon10
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Thanks for the fix, this looks good to me. Can you sign your commit to get past the DCO check?
jondeaton
force-pushed
the
fix-warning
branch
from
f750a06
to
252787e
Compare
Yep sure thing, I think I've signed off properly now. |
|
Looks like the first commit is still not signed off, could you try to sign-off all commits? Thanks! @jondeaton |
Signed-off-by: Jon Deaton <jon.deaton@evolutionaryscale.ai>
for more information, see https://pre-commit.ci Signed-off-by: Jon Deaton <jon.deaton@evolutionaryscale.ai>
jondeaton
force-pushed
the
fix-warning
branch
from
252787e
to
9abde8f
Compare
|
Yeah, sorry about that - new to the process. I think I've signed off on all of them now? |
ksivaman
requested changes
Sep 6, 2024
There was a problem hiding this comment.
On second thought, we had this change previously in a PR and ended up reverting it here. Since this API is a relatively new addition to pytorch, we would want it to be accompanied by a pytorch version check so that versions 2.3.1 or older aren't broken!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warning about deprecation of
torch.get_autocast_gpu_dtype