Dump v #200
Open
Dump v #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation previewhttps://nvidia-merlin.github.io/HierarchicalKV/review/pr-200 |
jiashuy
reviewed
Aug 14, 2024
| template <class K, class V, class S, | ||
| template <typename, typename> class PredFunctor, | ||
| int TILE_SIZE> | ||
| __global__ void dump_kernel_v2(const Table<K, V, S>* __restrict table, |
jiashuy
reviewed
Aug 14, 2024
include/merlin/core_kernels.cuh
Outdated
| int dim = table->dim; | ||
| auto g = cg::tiled_partition<TILE_SIZE>(cg::this_thread_block()); | ||
|
|
||
| __shared__ block_acc; |
|
Hi, @jiashuy This PR is under development yet. I'll fix the problems ASAP. |
|
/blossom-ci |
2 similar comments
|
/blossom-ci |
|
/blossom-ci |
jiashuy
reviewed
Aug 21, 2024
| cudaEventCreate(&start); | ||
| cudaEventCreate(&stop); | ||
| cudaEventRecord(start); | ||
| table->export_batch_if<ExportIfPredFunctor>( |
There was a problem hiding this comment.
There are total three kernel templates, and has each kernel been tested? If not is it necessary to test each kernel.
There was a problem hiding this comment.
I've tested them seperately, but not added them into the tests case. Since it's an internal option not for public API.
…memory wavefronts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the costs in microseconds of
dump_kernelanddump_kernel_v2on both pinned host or device output on 2^24 capacity table with half of the contents are exported. The table values are stored on pure GPU buckets.capacity: 2^24, and the table is full when running the export_batch_if
num exported: 8388771
dim: 64
A100 + AMD
H20 + Intel