Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds users with admin privileges to home screen #1520

Merged
merged 1 commit into from
Feb 10, 2025
Merged

feat: adds users with admin privileges to home screen #1520

merged 1 commit into from
Feb 10, 2025

Conversation

Matte22
Copy link
Collaborator

@Matte22 Matte22 commented Feb 10, 2025

resolves #1451
resolves #418

API:

  1. getUsers operation ID gained a query param of 'privilege' whos values can be ["admin" , "create_collection"]. This will return users with the specified privilege.

Client

  1. Adds an env var to control the display of app managers on the home page "STIGMAN_CLIENT_DISPLAY_APPMANAGERS"
  2. Adds card on home screen that lists display names and emails of users with "admin" privilege.
  3. Additionally adds new css which allows for the new card aswell as the "Welcome" card to be scrollable when content overflows.

@Matte22 Matte22 added documentation Improvements or additions to documentation API UI tests OAS labels Feb 10, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'nuwcdivnpt_stig-manager-client'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.6% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'nuwcdivnpt_stig-manager-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@csmig csmig merged commit 189fc23 into main Feb 10, 2025
13 checks passed
Matte22 added a commit to Matte22/stig-manager that referenced this pull request Feb 10, 2025
@Matte22 @cd-rite @csmig
Binary tests test (#7)
3294688 
* adds missed tests for metrics (NUWCDIVNPT#1500)

* test: adds missing test cases for admin and create_collection (NUWCDIVNPT#1505)

* chore: 1.5.3 updates (NUWCDIVNPT#1499)

* missing descriptions for a few detailed metrics (NUWCDIVNPT#1511)

* fix: add ruleIds to ReviewAssetRuleRead; remove String255 references (NUWCDIVNPT#1510)

* fix: on unregistering a user, clear userGroups and request userGroups projection. (NUWCDIVNPT#1514)

* fix: user-defined jwt claims handling (NUWCDIVNPT#1517)

* feat: adds users with admin privileges to home screen (NUWCDIVNPT#1520)

* test

* test

* test merge

* test

---------

Co-authored-by: cd-rite <61710958+cd-rite@users.noreply.github.com>
Co-authored-by: csmig <33138761+csmig@users.noreply.github.com>
@cd-rite cd-rite deleted the adduserstohome branch February 26, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API documentation Improvements or additions to documentation OAS tests UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display App Managers and contact info in Home tab -> Resources Home widgets need scroll bars
2 participants
@Matte22 @csmig