fix: handling of user-defined jwt claims #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Matte22
approved these changes
Feb 10, 2025
Matte22
added a commit
to Matte22/stig-manager
that referenced
this pull request
Feb 10, 2025
* adds missed tests for metrics (NUWCDIVNPT#1500) * test: adds missing test cases for admin and create_collection (NUWCDIVNPT#1505) * chore: 1.5.3 updates (NUWCDIVNPT#1499) * missing descriptions for a few detailed metrics (NUWCDIVNPT#1511) * fix: add ruleIds to ReviewAssetRuleRead; remove String255 references (NUWCDIVNPT#1510) * fix: on unregistering a user, clear userGroups and request userGroups projection. (NUWCDIVNPT#1514) * fix: user-defined jwt claims handling (NUWCDIVNPT#1517) * feat: adds users with admin privileges to home screen (NUWCDIVNPT#1520) * test * test * test merge * test --------- Co-authored-by: cd-rite <61710958+cd-rite@users.noreply.github.com> Co-authored-by: csmig <33138761+csmig@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1515
config.oauth.claims.privilegesto conform to MySQL JSON path syntax by double-quoting all object properties.config.oauth.claims.privilegesto surround the path statement with single-quotes in order to support the double-quoted path componentsformatChain()toformatJsChain()for clarityconfig.oauth.claimsfor clarity:privileges=>privilegesChainprivilegesPath=>privilegesoauth.claimsfromEnv.jsserved to the web app since it is no longer used by any web app codeconstdeclaration inUser.js$.namewith$.${config.oauth.claims.name}inCollectionService.jsSTIGMAN_JWT_*_CLAIMenvironment variables to describe which variables MUST NOT be nested and MUST be valid ECMAScript identifiers, or MAY be nested and SHOULD be valid ECMAScript identifiers.STIGMAN_JWT_PRIVILEGES_CLAIMis the only variable documented as allowing nesting.