Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Form Container #27

Conversation

bransometan
Copy link
Contributor

Pull Request

Description

[Provide a brief description of the changes in this pull request.]

Related Issues

[Reference any related issues that this pull request addresses or resolves.]

Checklist

Please review and check the following before submitting your pull request:

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have written tests for my changes (if applicable).
  • All new and existing tests passed.
  • I have updated the documentation accordingly (if applicable).
  • I have added comments to my code, particularly in areas that may be confusing.

Screenshots (if applicable)

[Include any relevant screenshots or GIFs to visually demonstrate the changes.]

Desktop

image

Mobile

image

Additional Information

[Include any additional information that might be helpful for reviewers or maintainers.]
Not sure if I am doing it correctly. Do update me if changes is required. I think the height of the inner component depends on the size of the 2 components in login form.

Reviewer Notes

[Optional: Include specific instructions or notes for reviewers, if necessary.]

@gnimnix
Copy link
Contributor

gnimnix commented Feb 16, 2024

hi @bransometan , please request me as reviewer and merge into epic/DEV-3-authentication instead of main!

@bransometan bransometan changed the base branch from main to epic/DEV-3-authentication February 16, 2024 05:26
@bransometan bransometan requested a review from gnimnix February 16, 2024 05:26
@bransometan bransometan self-assigned this Feb 16, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should not be changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should not be changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should not be changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should not be changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file for?

@gnimnix
Copy link
Contributor

gnimnix commented Feb 18, 2024

@bransometan think you changed some files that should not be changed and committed the changes already. Suggest you create another branch from epic/DEV-3-authentication, you can call it TAS-2-login-form-containers-edited. Then copy the files over.

@bransometan
Copy link
Contributor Author

Have edited the changes and submitted another PR

@gnimnix gnimnix closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants