3.0 Release #448
Open
3.0 Release #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update default behaviors
Replace deploy with trusted publisher workflow for pypi
python 3.12 will be the new base version of python that we test to
Fix issue #370 (energy_from_power returns incorrect index for shifted hourly data)
Bump tornado from 6.3.3 to 6.4.2 in /docs
Co-authored-by: Michael Deceglie <mdeceglie@users.noreply.github.com>
add pvlib clearsky filter test in analysis chain
Co-authored-by: Michael Deceglie <mdeceglie@users.noreply.github.com>
Co-authored-by: Michael Deceglie <mdeceglie@users.noreply.github.com>
Co-authored-by: Michael Deceglie <mdeceglie@users.noreply.github.com>
Fix issue #313 (different results with Nan's and Zeros in power series)
…tests Fix pandas deprecation warnings in tests
Bump jinja2 from 3.0.0 to 3.1.5 in /docs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #448 +/- ##
===========================================
+ Coverage 69.96% 96.21% +26.25%
===========================================
Files 12 12
Lines 2111 2274 +163
===========================================
+ Hits 1477 2188 +711
+ Misses 634 86 -548 ☔ View full report in Codecov by Sentry. |
martin-springer
approved these changes
Jan 3, 2025
| @@ -55,36 +53,39 @@ The preferred method for degradation rate estimation is the year-on-year | |||
| (YOY) approach (Jordan 2018), available in :py:func:`.degradation.degradation_year_on_year`. | |||
| The YOY calculation yields in a distribution of degradation rates, the | |||
| central tendency of which is the most representative of the true | |||
| degradation. The width of the distribution provides information about | |||
| degradation. We note that the workflow described above and implimented in | |||
There was a problem hiding this comment.
Suggested change
| degradation. We note that the workflow described above and implimented in | |
| degradation. We note that the workflow described above and implemented in |
| "temperature_cell_ref": 25, | ||
| "gamma_pdc": self.gamma_pdc} | ||
| warnings.warn( | ||
| "Temperature coefficient not passed in to TrendAnalysis" |
There was a problem hiding this comment.
Suggested change
| "Temperature coefficient not passed in to TrendAnalysis" | |
| "Temperature coefficient not passed in to TrendAnalysis." |
| "gamma_pdc": self.gamma_pdc} | ||
| warnings.warn( | ||
| "Temperature coefficient not passed in to TrendAnalysis" | ||
| ". No temperature correction will be conducted." |
There was a problem hiding this comment.
Suggested change
| ". No temperature correction will be conducted." | |
| "No temperature correction will be conducted." |
| decomposition_type='multiplicative', bootstrap_seed=None | ||
| ): | ||
| ''' | ||
| Generate bootstrap samples based a time series signal and its model fit |
There was a problem hiding this comment.
Suggested change
| Generate bootstrap samples based a time series signal and its model fit | |
| Generate bootstrap samples based on a time series signal and its model fit |
|
|
||
| Bug fixes | ||
| --------- | ||
| * Set marker linewidth to zero in `rdtools.plotting.degradation_summary_plots` (:pull:`433`) |
There was a problem hiding this comment.
Suggested change
| * Set marker linewidth to zero in `rdtools.plotting.degradation_summary_plots` (:pull:`433`) | |
| * Set marker linewidth to zero in `rdtools.plotting.degradation_summary_plots` (:issue:`408`, :pull:`433`) |
| --------- | ||
| * Set marker linewidth to zero in `rdtools.plotting.degradation_summary_plots` (:pull:`433`) | ||
| * Fix :py:func:`~rdtools.normalization.energy_from_power` returns incorrect index for shifted hourly data (:issue:`370`, :pull:`437`) | ||
| * Add warning to clearsky workflow when ``power_expected`` is passed by user (:pull:`439`) |
There was a problem hiding this comment.
Suggested change
| * Add warning to clearsky workflow when ``power_expected`` is passed by user (:pull:`439`) | |
| * Add warning to clearsky workflow when ``power_expected`` is passed by user (:issue:`271`, :pull:`439`) |
|
After merging this PR, I think it would be a good time to rename the default branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of these changes has been individually reviewed in PRs to
development. Let's make sure that everything is polished for the 3.0 release.__init__.py