Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

449 mad fn #459

Closed
wants to merge 6 commits into from
Closed

449 mad fn #459

wants to merge 6 commits into from

Conversation

cdeline
Copy link
Contributor

@cdeline cdeline commented Mar 15, 2023 •
edited
Loading

Update to the calculation of MAD to improve how it handles 2D arrays and dataframes.

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with GUI
  • New functions added to __init__.py
  • manualapi.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

cdeline added 5 commits March 14, 2023 06:03
@cdeline
Update mismatch.py mad_fn to handle arrays and dataframes with 1D cal…
54f44b5 
…culations.
@cdeline
mismatch.mad_fn updated with new axis parameter. Default = 0 (index).
7000baf 
If a 2D array or dataframe is passed in, MAD is calculated for each row (or column if `index=1` is used).
Addresses the mad_fn errors in #449
@cdeline
Update mismatch.py mad_fn to handle arrays and dataframes with 1D cal…
6b4f46a 
…culations.
@cdeline
mismatch.mad_fn updated with new axis parameter. Default = 0 (index).
5e33dbc 
If a 2D array or dataframe is passed in, MAD is calculated for each row (or column if `index=1` is used).
Addresses the mad_fn errors in #449
@cdeline
Merge branch '449_mad_fn' of https://github.com/NREL/bifacial_radiance …
28a1e5c 
…into 449_mad_fn
@cdeline
Copy link
Contributor Author

cdeline commented Mar 15, 2023

Still want to add a pytest for mismatch_fit3

@cdeline cdeline mentioned this pull request Nov 9, 2023
Merged
@cdeline
Copy link
Contributor Author

cdeline commented Nov 9, 2023

Fixed by #485

@cdeline cdeline closed this Nov 9, 2023
@cdeline cdeline deleted the 449_mad_fn branch November 9, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cdeline