-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrates Timeslices, change time-series to PU #32
Merged
+254
−185
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c3beb83
Cost Function definition and various fixes for internal merge
ktehranchi 6e56af7
Makes placeholders for cost functions of each model type. Output VOM.
ktehranchi 98f8b9a
address comments
ktehranchi 6830016
rename rating and active_power
ktehranchi 8ea579d
Changes max_active_power to PU
ktehranchi 1b3b860
WIP ext data to json
ktehranchi fd3df44
remove ext data export function. to use each component ext field
ktehranchi f815430
Fix ordering of date_from date_to filtering in _get_model_data
ktehranchi dbdd0c8
Adds timeslice data. WIP parsing timeslice data properly
ktehranchi fac75b0
Adds timeslice data parsing and logic. refactor _get_value
ktehranchi 1631664
further simplify get_value logic
ktehranchi 7ebfffa
Fixes logic on parsing date_from date_to with default data
ktehranchi cccf109
Improves logger warning, cleans up old comments
ktehranchi a5741fc
Fixes #25
ktehranchi 6d18a1f
Fixes #31
ktehranchi a5d13e8
fix enum caps.
ktehranchi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this rating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to rating since active_power in Sienna only refers to the initial set point of active power (MW). Although rating in Sienna is (MVA), I still think rating makes more sense than active power since we're assuming these plexos models are not running models with reactive power.
I considered using max_active_power, but I reserved that for the plexos Rating field since that is typically used to specify time-varying max_active_power limits in combination with the Rating Factor field.