Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrates Timeslices, change time-series to PU #32

Merged
merged 16 commits into from
Sep 12, 2024
Merged

Conversation

ktehranchi
Copy link
Collaborator

@ktehranchi ktehranchi commented Sep 12, 2024

Changes and Fixes:

  • Integrated timeslcies with new timeslice and timeslice_value fields from plexosdb query and associated parsing logic
  • Renames variables to be more intuitive. Now variables and fields for max_active_power/active_power/rating match the Sienna definitions of these terms instead of plexos definition.
  • Changes export of max_active_power to be per-unit
  • Fixes read-order of date_from / date_to filtering which caused all retiring units to previously not be included in system
  • Refactors self._get_value()
  • Fix improve: Print Missing fields when component skipped #25
  • Fix Bug: Exporter Components with ',' comma in name #31

@ktehranchi ktehranchi requested a review from pesap September 12, 2024 00:47
@@ -18,7 +18,7 @@
"Load Risk": "load_risk",
"Loss Incr": "losses",
"Maintenance Rate": "planned_outage_rate",
"Max Capacity": "active_power",
"Max Capacity": "rating",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this rating?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to rating since active_power in Sienna only refers to the initial set point of active power (MW). Although rating in Sienna is (MVA), I still think rating makes more sense than active power since we're assuming these plexos models are not running models with reactive power.

I considered using max_active_power, but I reserved that for the plexos Rating field since that is typically used to specify time-varying max_active_power limits in combination with the Rating Factor field.

@pesap
Copy link
Collaborator

pesap commented Sep 12, 2024

LGTM!

@ktehranchi ktehranchi merged commit fb21275 into main Sep 12, 2024
7 checks passed
@ktehranchi ktehranchi deleted the kt/pu_availability branch September 12, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Exporter Components with ',' comma in name improve: Print Missing fields when component skipped
2 participants