-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrates Timeslices, change time-series to PU #32
Conversation
@@ -18,7 +18,7 @@ | |||
"Load Risk": "load_risk", | |||
"Loss Incr": "losses", | |||
"Maintenance Rate": "planned_outage_rate", | |||
"Max Capacity": "active_power", | |||
"Max Capacity": "rating", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this rating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to rating since active_power in Sienna only refers to the initial set point of active power (MW). Although rating in Sienna is (MVA), I still think rating makes more sense than active power since we're assuming these plexos models are not running models with reactive power.
I considered using max_active_power, but I reserved that for the plexos Rating field since that is typically used to specify time-varying max_active_power limits in combination with the Rating Factor field.
LGTM! |
Changes and Fixes:
self._get_value()