Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (plexos): Bugs on availability and Value Curves, exports extra data as JSON #14

Merged
merged 4 commits into from
Aug 29, 2024
Merged

fix (plexos): Bugs on availability and Value Curves, exports extra data as JSON #14

merged 4 commits into from
Aug 29, 2024

Conversation

ktehranchi
Copy link
Collaborator

Fixed a few bugs on:

  • Modifying storage unit storage_capacity with availability factor
  • Setting min_active_power for HydroUnits where Min Energy Hourly is set
  • Temporary fix for Hydro-max energy monthly to properly export base_power

Implements:

  • export of extra data to json file. Pint Quantity objects are converted tuples.

@ktehranchi ktehranchi closed this Aug 28, 2024
@ktehranchi
Copy link
Collaborator Author

Closed because I didn't export all object data- only generators. Fixing then will re-open

@ktehranchi ktehranchi reopened this Aug 28, 2024
@ktehranchi ktehranchi requested a review from pesap August 28, 2024 23:04
pesap
pesap approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@pesap pesap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pesap pesap merged commit 3e6d6dd into main Aug 29, 2024
14 checks passed
@pesap pesap deleted the kt/availability_fixes branch August 29, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pesap pesap pesap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktehranchi @pesap