Merge pull request #431 from luke-kiernan/set_name_no_op

set_name to own name is a no-op, not an error
NREL-Sienna · Feb 1, 2025 · 6740245 · 6740245
2 parents 17ccd3b + 642a052
commit 6740245
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/components.jl b/src/components.jl
@@ -365,6 +365,9 @@ function set_name!(
 ) where {T <: InfrastructureSystemsComponent}
     throw_if_not_attached(components, component)
     if haskey(components.data[T], name)
+        if components.data[T][name] === component
+            return
+        end
         throw(ArgumentError("A component of type $T and name = $name is already stored"))
     end
 

diff --git a/test/test_system_data.jl b/test/test_system_data.jl
@@ -63,6 +63,7 @@ end
     name = "component1"
     component = IS.TestComponent(name, 5)
     IS.add_component!(data, component)
+    @test IS.set_name!(data, component, name) isa Any # shouldn't throw.
 
     new_name = "component1-new"
     IS.set_name!(data, component, new_name)