Fix memory error when chv and rv are used as calibration parameters.

[hellkite500]

Memory errors pop up when using chv as a BMI calibratable parameter. This is due to the time delay histogram not being the correct size when set_value calls calc_time_delay_histogram since chv and rv affect the values of tch in convert_dist_to_histords which in turn determines the number of ordinates in the time_delay_histogram.

This PR checks if the number of ordinates has changed and dynamically reallocates the histogram array.

Additions

• Add chv and rv to bmi unit test parameter list

Changes

• topmodel.c reallocate time_delay_histogram pointer when size changes

Testing

1. Unit tests passing local with address sanitizer enabled using clang compiler.

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

• Linux
• MacOS

[PhilMiller]

Does Address Sanitizer happen to catch this with just the unit test change and not the code change? That would be a great source of confidence in the fix (which looks good to me)

[hellkite500]

Yes, adding the parameters to the unit test triggered the sanitizer. The proposed fix tested with no errors.

[Ben-Choat]

Everything looks good and has solved the issue.