Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PET and Topmodel to get bug, sanitizer/valgrind, and -Werror fixes #785

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Mar 29, 2024

Changes

Fixes #776

Testing

  1. Github CI

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • macOS

@PhilMiller PhilMiller mentioned this pull request Mar 29, 2024
12 tasks
@PhilMiller PhilMiller marked this pull request as ready for review March 29, 2024 23:54
@PhilMiller PhilMiller changed the title Update PET to get bug and -Werror fixes Update PET and Topmodel to get bug, sanitizer, and -Werror fixes Mar 30, 2024
@PhilMiller PhilMiller changed the title Update PET and Topmodel to get bug, sanitizer, and -Werror fixes Update PET and Topmodel to get bug, sanitizer/valgrind, and -Werror fixes Mar 30, 2024
@hellkite500 hellkite500 merged commit 00bcc3d into NOAA-OWP:master Apr 1, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/update-pet branch April 1, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update topmodel submodule for critical fix
2 participants