Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all C++ BMI modules to reference virtual destructor #831

Closed
3 tasks done
PhilMiller opened this issue Jun 7, 2024 · 1 comment · Fixed by #832
Closed
3 tasks done

Update all C++ BMI modules to reference virtual destructor #831

PhilMiller opened this issue Jun 7, 2024 · 1 comment · Fixed by #832
Assignees

Comments

@PhilMiller
Copy link
Contributor

PhilMiller commented Jun 7, 2024

csdms/bmi-cxx#12 has been merged. Now we need coordinated updates of our internal and OWP-wide C++ BMI modules to make sure that they all consistently start to reference the revised definition in clean, atomic steps.

Under the model engine team's purview, there's

Under (I think) the Formulation and/or Soil team's purview, there's references in

@PhilMiller
Copy link
Contributor Author

@nels - I'm calling it a night. Let's talk tomorrow about how to coordinate testing and merging the batch that all need to go together.

@PhilMiller PhilMiller linked a pull request Jun 11, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants