generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viz rds parameter group tuning #689
Merged
Merged
Commits on Mar 22, 2024
-
Fixes bug with viz_db_ingest Lambda (#652)
I found a bug while attempting to execute an archive case, and while fixing it also noticed another messy section of code that I cleaned up. The bug was that if a CSV file failed to upload, it would supposedly work on the retry, but turns out it wasn't actually working, but failing silently. This is because the end of the in-memory file object was being reached just prior to failing, and so on the retry, there is nothing left of the file to load without first doing a `f.seek(0)`. The messy part of the code was an unnecessary `with` context surrounding a large block of code in which the actual couple of lines that did need the `with` context had what was essentially a duplicate context. I deleted the outer, unnecessary context and thus indented everything back one level.
Configuration menu - View commit details
-
Copy full SHA for 4c34bb8 - Browse repository at this point
Copy the full SHA 4c34bb8View commit details
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0cc9b78 - Browse repository at this point
Copy the full SHA 0cc9b78View commit details
Commits on Apr 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 63a695e - Browse repository at this point
Copy the full SHA 63a695eView commit details
Commits on Apr 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 04d0c9c - Browse repository at this point
Copy the full SHA 04d0c9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94ce0ed - Browse repository at this point
Copy the full SHA 94ce0edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b6947a - Browse repository at this point
Copy the full SHA 6b6947aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1703be0 - Browse repository at this point
Copy the full SHA 1703be0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.