Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viz rds parameter group tuning #689

Merged
merged 7 commits into from
Apr 3, 2024

Commits on Mar 22, 2024

  1. Fixes bug with viz_db_ingest Lambda (#652)

    I found a bug while attempting to execute an archive case, and while
    fixing it also noticed another messy section of code that I cleaned up.
    
    The bug was that if a CSV file failed to upload, it would supposedly
    work on the retry, but turns out it wasn't actually working, but failing
    silently. This is because the end of the in-memory file object was being
    reached just prior to failing, and so on the retry, there is nothing
    left of the file to load without first doing a `f.seek(0)`.
    
    The messy part of the code was an unnecessary `with` context surrounding
    a large block of code in which the actual couple of lines that did need
    the `with` context had what was essentially a duplicate context. I
    deleted the outer, unnecessary context and thus indented everything back
    one level.
    shawncrawley authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    4c34bb8 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Configuration menu
    Copy the full SHA
    0cc9b78 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Configuration menu
    Copy the full SHA
    63a695e View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Configuration menu
    Copy the full SHA
    04d0c9c View commit details
    Browse the repository at this point in the history
  2. final changes

    nickchadwick-noaa committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    94ce0ed View commit details
    Browse the repository at this point in the history
  3. more updates

    nickchadwick-noaa committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    6b6947a View commit details
    Browse the repository at this point in the history
  4. more changes

    nickchadwick-noaa committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    1703be0 View commit details
    Browse the repository at this point in the history