Viz rds parameter group tuning #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found a bug while attempting to execute an archive case, and while fixing it also noticed another messy section of code that I cleaned up. The bug was that if a CSV file failed to upload, it would supposedly work on the retry, but turns out it wasn't actually working, but failing silently. This is because the end of the in-memory file object was being reached just prior to failing, and so on the retry, there is nothing left of the file to load without first doing a `f.seek(0)`. The messy part of the code was an unnecessary `with` context surrounding a large block of code in which the actual couple of lines that did need the `with` context had what was essentially a duplicate context. I deleted the outer, unnecessary context and thus indented everything back one level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.