Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ana High Flow Mag Alaska service #670

Merged
merged 2 commits into from
Apr 19, 2024
Merged

ana High Flow Mag Alaska service #670

merged 2 commits into from
Apr 19, 2024

Conversation

KatherinePowell-NOAA
Copy link
Contributor

@KatherinePowell-NOAA KatherinePowell-NOAA commented Mar 22, 2024

New HFM service for Alaska domain (#661)

Test new static service here:
https://maps-testing.water.noaa.gov/portal/apps/mapviewer/index.html?layers=cb0690428fb64033bbbed22bfc01c637

Additions

ana_high_flow_magnitude_ak_noaa.mapx
*2 YAML files - 1) viz_initialize_pipeline/product_configs/ and 2) viz_db_postprocess_sql/products:
ana_high_flow_magnitude_ak.yml
ana_high_flow_magnitude_ak.sql

Removals

Changes

Testing

Screenshots

image
image

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@KatherinePowell-NOAA
Copy link
Contributor Author

@shawncrawley - I have added the viz_initialize_pipeline/product_configs/ana_high_flow_magnitude_ak.yml file

Copy link
Collaborator

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@KatherinePowell-NOAA KatherinePowell-NOAA removed the request for review from MonicaStone-NOAA April 2, 2024 19:02
@nickchadwick-noaa nickchadwick-noaa merged commit 9b777b3 into ti Apr 19, 2024
1 check passed
@nickchadwick-noaa nickchadwick-noaa deleted the ana_hfm_alaska branch April 19, 2024 16:12
@KatherinePowell-NOAA KatherinePowell-NOAA added this to the V2.1.6 milestone May 22, 2024
@KatherinePowell-NOAA KatherinePowell-NOAA changed the title adding HFM Alaska files - mapx, sql, yml Create ana HFM Alaska service Aug 13, 2024
@KatherinePowell-NOAA KatherinePowell-NOAA changed the title Create ana HFM Alaska service ana High Flow Mag Alaska service Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants