Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viz EC2 Services to Lambda - Part 3b - Wrap Up #602

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

TylerSchrag-NOAA
Copy link
Contributor

This PR wraps up the migration of the remaining EC2 VPP services (ensemble-based probability services + ana anomaly) to the serverless step functions. It includes:

  • Couple minor bug fixes to previous PRs
  • Initialize Pipeline / Step function logic to choose the correct python_preprocessing lambda function during python preprocessing steps, based on a flag in the product config files.

@TylerSchrag-NOAA TylerSchrag-NOAA added the enhancement New feature or request label Dec 19, 2023
@TylerSchrag-NOAA TylerSchrag-NOAA self-assigned this Dec 19, 2023
@TylerSchrag-NOAA TylerSchrag-NOAA linked an issue Dec 19, 2023 that may be closed by this pull request
shawncrawley
shawncrawley previously approved these changes Dec 20, 2023
Copy link
Collaborator

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - well done!

Copy link
Collaborator

@nickchadwick-noaa nickchadwick-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced the remaining "2gb" references of the python processing Lambda with the new "3gb" one. Let me know if this was in error.

@nickchadwick-noaa nickchadwick-noaa merged commit eb7ef8d into ti Jan 3, 2024
1 check passed
@nickchadwick-noaa nickchadwick-noaa deleted the Viz-EC2-Services-to-Lambda---Fixes-1 branch January 3, 2024 17:05
nickchadwick-noaa added a commit that referenced this pull request Feb 21, 2024
This PR wraps up the migration of the remaining EC2 VPP services
(ensemble-based probability services + ana anomaly) to the serverless
step functions. It includes:

- Couple minor bug fixes to previous PRs
- Initialize Pipeline / Step function logic to choose the correct
python_preprocessing lambda function during python preprocessing steps,
based on a flag in the product config files.

---------

Co-authored-by: Nick Chadwick <nick.chadwick@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viz EC2 Services to Lambda - Part 3 - Anomaly
3 participants