fixed PEP8 F633, and PEP8 problems in the documentation build #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhartnett
changed the title
edwardhartnett
requested review from
MatthewPyle-NOAA,
ShunLiu-NOAA,
JacobCarley-NOAA and
BenjaminBlake-NOAA
as code owners
MatthewPyle-NOAA
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
We have some PEP8 tests working, but I had to turn one of them off (F633) when we switched to the new main branch. There were some python2 style print statements in the code.
This PR fixes those print statements and turns that checking back on in CI.
Also I fix the PEP8 problems of the documentation conf.py file. This is documentation code, not workflow code, so seems safe to fix. (More work on the documentation build is coming so fixing these now is helpful).
TESTS CONDUCTED:
N/A
Machines/Platforms:
N/A
Test cases:
N/A
ISSUE:
Part of #456