Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JEDI-based analysis calculation #28

Closed
wants to merge 35 commits into from
Closed

Conversation

DavidNew-NOAA
Copy link
Contributor

@DavidNew-NOAA DavidNew-NOAA commented Sep 23, 2024

This PR is a companion to GDASApp PR #1293 and Global-Workflow PR #2949.

It does two things:

  1. It adds the YAML for the fv3jedi_analcalc utility, introduced in the above GDASApp PR.
  2. It prepares the variational and ensemble DA FV3 increment converters to write increments using the FMS non-restart format created in FV3-JEDI PR #1251. The variational analysis job will also now write using this format for its intermediate increment before conversion to the FV3-readable format.

@DavidNew-NOAA DavidNew-NOAA changed the title Feature/calcanl Add JEDI-based analysis calculation Oct 24, 2024
@DavidNew-NOAA DavidNew-NOAA marked this pull request as ready for review October 24, 2024 00:52
@DavidNew-NOAA
Copy link
Contributor Author

@danholdaway Now that I've added the atmosphere_ prefix to analysis_variables in the atmosphere test template, the client testing fails. I assume it's using the ````developbranchparm/atm/jcb-base.yaml.j2``` which isn't yet updated, and that's why it's failing?

@danholdaway
Copy link
Collaborator

Actually you've stumbled upon something that isn't ideal. The key analysis_variables also needs to be a generic one because it is used here: https://github.com/NOAA-EMC/jcb-algorithms/blob/43d8ff6ba14baf9402ee58d0f3351a143c21211b/3dvar.yaml.j2#L19

So you need both analysis_variables and atmosphere_analysis_variables. Just use the YAML anchor in the testing YAML and JCB base in GDASapp. You can't add a model specific algorithm with a generic key and you can't use a model specific key in a generic algorithm. 🙃

DavidNew-NOAA and others added 2 commits November 1, 2024 11:20
Co-authored-by: Dan Holdaway <27729500+danholdaway@users.noreply.github.com>
@DavidNew-NOAA
Copy link
Contributor Author

I would say this PR is complete, but DO NOT MERGE, because I'm holding off on the associated GW and GDASApp PRs until I have clarity on GW PR #2992 and ensemble recentering, both of which I hope to discuss with @aerorahul next week.

@DavidNew-NOAA
Copy link
Contributor Author

Closing for now while I overhaul this set of PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants