-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JEDI-based analysis calculation #28
Conversation
model/atmosphere/atmosphere_final_increment_cubed_sphere.yaml.j2
Outdated
Show resolved
Hide resolved
model/atmosphere/atmosphere_final_increment_fms_nonrestart.yaml.j2
Outdated
Show resolved
Hide resolved
@danholdaway Now that I've added the atmosphere_ prefix to |
Actually you've stumbled upon something that isn't ideal. The key analysis_variables also needs to be a generic one because it is used here: https://github.com/NOAA-EMC/jcb-algorithms/blob/43d8ff6ba14baf9402ee58d0f3351a143c21211b/3dvar.yaml.j2#L19 So you need both analysis_variables and atmosphere_analysis_variables. Just use the YAML anchor in the testing YAML and JCB base in GDASapp. You can't add a model specific algorithm with a generic key and you can't use a model specific key in a generic algorithm. 🙃 |
Co-authored-by: Dan Holdaway <27729500+danholdaway@users.noreply.github.com>
I would say this PR is complete, but DO NOT MERGE, because I'm holding off on the associated GW and GDASApp PRs until I have clarity on GW PR #2992 and ensemble recentering, both of which I hope to discuss with @aerorahul next week. |
Closing for now while I overhaul this set of PRs |
This PR is a companion to GDASApp PR #1293 and Global-Workflow PR #2949.
It does two things:
fv3jedi_analcalc
utility, introduced in the above GDASApp PR.