Update masking_mod.F90 #84
Conversation
Changed minlat to -78
src/ocnicepost.fd/masking_mod.F90
Outdated
| @@ -27,7 +27,7 @@ subroutine remap_masks(vfill) | |||
| ! local variables | |||
| integer :: rc, ncid, varid, n | |||
| character(len=240) :: wgtsfile | |||
| real :: minlat = -79.75 | |||
| real :: minlat = -78.00 | |||
There was a problem hiding this comment.
@AminIlia-NOAA Did you verify that this minimum is valid for all OCN resolutions, meaning no spurious interpolated values appear at any rectilinear resolution?
The last valid ocean grid point is at
1/4deg 78.525S
1/2deg 77.72S
1deg 77.77S
5deg 75S
There was a problem hiding this comment.
@DeniseWorthen Thank you for your comment.
Yes, this should resolve it. However as I mention the main problem could be source from another thing. We will loose some computational nodes for 1/4 deg however those are outside ocean edge. Please let me know your opinion.
Changed minlat to -78.63 to avoid loosing any node results in 1/4 deg resolution.
|
@aerorahul It wasn't clear to me that it had actually been tested and confirmed to work for all resolutions vs just "it should resolve it". Perhaps the latest commit changing the value was the result of that testing? |
No sure. If you agree with the change and think it should fix the issue, please approve and we can merge. It will get tested when we run the tests in the global-workflow. If an issue exists then, we can follow up with another PR. |
Changed minlat in masking_mod.F90 to -78
Resolves ##83
-->
Type of change
Change characteristics
-->
Checklist