Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync develop branch 20241220 to dev/ufs-weather-model #1337

Draft
wants to merge 57 commits into
base: dev/ufs-weather-model
Choose a base branch
from

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

Pull Request Summary

This PR brings in the develop branch to dev/ufs-weather-model.

Description

More details to follow.

Issue(s) addressed

Commit Message

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

mickaelaccensi and others added 30 commits July 31, 2023 11:38
…efined in w3odatmd (size=15). Also, defined unit numbers for NDS(14) and NDS(15). (NOAA-EMC#1098)
…ST4 code (NOAA-EMC#1124)

Co-authored-by: Fabrice Ardhuin <fabrice.ardhuin@ifremer.fr>
MatthewMasarik-NOAA and others added 27 commits February 5, 2024 18:45
Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>
…ompiled with the OMPG switch. Also fixes truncation of build.log when running run_cmake_build. (NOAA-EMC#1191)

* Added screen output showing number of threads when OMP enabled.

* update build to get more info in logs (NOAA-EMC#46)

---------

Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Fabrice Ardhuin <fabrice.ardhuin@ifremer.fr>
Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com>
…OAA-EMC#1230)

---------

Co-authored-by: Edward Hartnett <edward.hartnett@noaa.gov>
Co-authored-by: Matthew Masarik <Matthew.Masarik@noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@clogin02.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: Ty Hesser <thesser1@gmail.com>
Co-authored-by: Tyler James Hesser <thesser1@carpenter09.hsn.ex4000.erdc.hpc.mil>
 Based on Meylan Horvat Bitz and Bennetts, Ocean Modelling, 2021. 

Co-Authors include: Erin Thomas, Cecilia Bitz, David Bailey, Nick Szapiro.
Co-authored-by: Erin Thomas <ac.ethomas@chrlogin1.lcrc.anl.gov>
 Conflicts:
	.github/workflows/intel.yml
	model/inp/ww3_ounf.inp
	model/src/w3gridmd.F90
	model/src/w3initmd.F90
	model/src/w3iogomd.F90
	model/src/w3ounfmetamd.F90
	model/src/w3sic4md.F90
@@ -459,7 +462,7 @@ SUBROUTINE W3INIT ( IMOD, IsMulti, FEXT, MDS, MTRACE, ODAT, FLGRD, FLGR2, FLGD,
!/ ------------------------------------------------------------------- /
!/ Parameter list
!/
INTEGER, INTENT(IN) :: IMOD, MDS(13), MTRACE(2), &
INTEGER, INTENT(IN) :: IMOD, MDS(15), MTRACE(2), &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of changes needed in the mesh cap code to align w/ the increased array size of MDS. See

integer :: mds(13) ! Note that nds is set to this in w3initmod

integer , intent(out) :: mds(13), ntrace(2)

@@ -1493,6 +1499,8 @@ SUBROUTINE W3WAVE ( IMOD, ODAT, TEND, STAMP, NO_OUT &

CALL INIT_GET_ISEA(ISEA, JSEA)

IF ((IOBP_LOC(JSEA).eq.1..or.IOBP_LOC(JSEA).eq. 3).and.IOBDP_LOC(JSEA).eq.1.and.IOBPA_LOC(JSEA).eq.0) THEN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if block is not properly indented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.