update to main 20240508 commit #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default values for the database transfer functions were incorrectly assiged as integer literals, recast to types using real32/64 but actually corresponding to whatever integer kind equals real32/64. We now simply assign it a literal value of -1. and rely on the compiler to handle the recasting. Although none of these functions were intended to be used, and -1 would probably be eventually cast into an appropriate real type, it is better to get this correct. Thanks to Keith Lindsay for suggesting this change.
Replace db array default values with real literals
…0240425 remove compiling warning
14 tasks
|
@DeniseWorthen @JessicaMeixner-NOAA : this is probably one of the simplest PR you ever had |
DeniseWorthen
approved these changes
May 9, 2024
JessicaMeixner-NOAA
approved these changes
May 9, 2024
14 tasks
|
Testing for #2259 is complete, please continue with the merge process, thank you. |
|
merging and close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a minor enhancement (see detail at mom-ocean#1623 ) for "removing compiling warning" PR which is in MOM6 main repo now. We need to pull it back to dev/emc in order to be parallel with main branch. This will pave the road for upcoming emc PR to main.