Fix NLnetLabs#981: dump_cache truncates large records. #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Jan 9, 2024
wcawijngaards
added a commit
that referenced
this pull request
Jan 9, 2024
|
Thank you for the fix, that looks to be the cause of the issue! The code is merged into the code repository. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jan 14, 2024
* nlnet/master: Changelog note for NLnetLabs#988. - Merge NLnetLabs#988: Fix NLnetLabs#981: dump_cache truncates large records. Fix NLnetLabs#981: dump_cache truncates large records.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue lies in the buffer sizes used by two functions: dump_rrset_line, which has a buffer size of 65535 to store a rrset string, and ssl_print_vmsg, which has a buffer size of only 1024 for printing a message. This mismatch is the root cause of the truncation.
To resolve this issue, I increased the output message buffer size from 1024 to 65535 to match the buffer size used for rrset strings. Additionally, I verified if the rrset string is truncated in packed_rr_to_string; if it is, unbound will output "BADRR" instead of printing the truncated message.