Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique DoT and DoH SSL contexts to allow for different ALPN #1222

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Unique DoT and DoH SSL contexts to allow for different ALPN #1222

merged 4 commits into from
Jan 20, 2025

Conversation

gthess
Copy link
Member

@gthess gthess commented Jan 15, 2025

To follow the recent interoperability TLS fixes from NSD.

I would appreciate a second pair of eyes especially for the tls_session_ticket_keys.

@gthess gthess requested a review from wcawijngaards January 15, 2025 16:20
@gthess gthess self-assigned this Jan 15, 2025
wcawijngaards
wcawijngaards approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sets the ALPN right on listening SSL transports.

The ssl ticket keys, are now using the same list in memory and same config for both types of transport. I guess if the ticket key is there it can provide session resumption.

daemon/unbound.c Show resolved Hide resolved
@gthess
Copy link
Member Author

gthess commented Jan 17, 2025

A couple of small additions for ALPN selection and optional context creation.

@gthess gthess merged commit e4483bb into master Jan 20, 2025
1 check passed
gthess added a commit that referenced this pull request Jan 20, 2025
@gthess
Changelog entry for #1222:
3f839ce 
- Merge #1222: Unique DoT and DoH SSL contexts to allow for different
  ALPN.
@gthess gthess deleted the features/separate_dot_doh_ssl_ctx branch January 20, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcawijngaards wcawijngaards wcawijngaards approved these changes

Assignees

@gthess gthess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gthess @wcawijngaards