Add unbound members group access to control key #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pemensik
force-pushed
the
unbound-control-group-key
branch
from
4222050 to
0d0f45c
Compare
Recent openssl genrsa does not use umask for generated keys. There is no strong reason why every member of unbound group should be able read server key. But control key would be quite useful to be group readable and to allow control access to whole group. Allowing access to control by group membership, not via sudo.
pemensik
force-pushed
the
unbound-control-group-key
branch
from
0d0f45c to
f4881bd
Compare
gthess
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Looks good to me.
The old situation was that the group was getting read access on keys and public certificates implicitly.
The current situation is that the group is not getting any read access on keys.
The new situation will be that the group will gain read access on the control key (the one clients need to connect to the server part- Unbound).
gthess
added a commit
that referenced
this pull request
Jan 24, 2025
- Merge #1220 from Petr Menšík, Add unbound members group access to control key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent openssl genrsa does not use umask for generated keys. There is no strong reason why every member of unbound group should be able read server key. But control key would be quite useful to be group readable and to allow control access to whole group. Allowing access to control by group membership, not via sudo.