Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats for discard-timeout and wait-limit #1159

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Conversation

wcawijngaards
Copy link
Member

The new discard-timeout and wait-limit options have been accounted as requestlist_exceeded in the statistics. But this mixes them with the request exceed number. The change makes their own statistics counters for them. The new statistics counters are num.queries_discard_timeout and num.queries_wait_limit.

@wcawijngaards wcawijngaards self-assigned this Oct 23, 2024
@wcawijngaards wcawijngaards requested a review from gthess October 23, 2024 09:42
Copy link
Member

@gthess gthess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, useful statistics to differentiate between performance drops and configuration drops of packets.

@gthess gthess merged commit 75967e7 into master Nov 1, 2024
1 check passed
@gthess gthess deleted the stat-discard-timeout branch November 1, 2024 14:53
gthess added a commit that referenced this pull request Nov 1, 2024
- Some clean up for stat_values.test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants