Do not allow backslashes in idexchange handles. #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenvh1
approved these changes
Aug 1, 2024
partim
added a commit
that referenced
this pull request
Aug 20, 2024
This PR adjusts the changes made in #304 and allows backslashes in idexchange handles if the compat feature is enabled. This is necessary to not break Krill installations that used backslashes in their handles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
ca::idexchange::Handleto not allow backslashes in its character set.The definition of a handle in appendix A of RFC 8183 reads:
which I read as not allowing backslashes (as the backslash escapes the hyphen).