Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setuped route and made navbar divided launches screen into 3 parts #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

setuped route and made navbar divided launches screen into 3 parts #11

wants to merge 3 commits into from

Conversation

amit-k-umar
Copy link

No description provided.

@AdityaPratap006
Copy link
Contributor

I reviewed your PR and would like to point out some things:

  1. Write the CSS of every component or screen in their separate files, instead of putting all the CSS in app.css, it will look cleaner that way.

  2. You had to create a launch detail screen for a particular launch, so before listing all the launches, there's no point in making the launch detail screen :)

And from now on, make the pull request to "amit-k-kumar-PR" branch and not the "master" branch.

@AdityaPratap006 AdityaPratap006 marked this pull request as draft October 6, 2020 14:32
@AdityaPratap006 AdityaPratap006 marked this pull request as ready for review October 6, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amit-k-umar @AdityaPratap006