PHP 8.4 Compatibility #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PHP Deprecated: some_function: Implicitly marking parameter $something as nullable is deprecated, the explicit nullable type must be used instead`
Naming classes _ is deprecated.
I have no idea what they're for. This is from upstream. Let's see what it does!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for PHP 8.4 and fixes for its deprecation. This library had two major sets of problems:
public function foo(string $bar = null)is no longer allowed. These have been updated to?stringto allow for null._as a class name is deprecated. The base class is named_, so that's been updated. This may cause BC breaks.I put some change notes in for our fork too.