Improve default delimiter names

cli_test.go

@@ -11,7 +11,7 @@ import (
 func TestCliBasicTypes(t *testing.T) {
 
 	os.Args = []string{"dummyprogramname", "-thing", "helloworld", "-b_bool", "-thonku_complex.Mff", "toaster"}
-	dummyConfig, err := LoadCli[testStruct](DefaultCliDelimiter)
+	dummyConfig, err := LoadCli[testStruct](CLIDelimiter)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -65,7 +65,7 @@ func TestCliComplexTypes(t *testing.T) {
 		"-complex_array", "text1,text2,text3", // Example for ComplexArray (implementsTextUnmarshaler)
 	}
 
-	dummyConfig, err := LoadCli[testCliStruct](DefaultCliDelimiter)
+	dummyConfig, err := LoadCli[testCliStruct](CLIDelimiter)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -116,7 +116,7 @@ func TestCliEmptyStringSlice(t *testing.T) {
 		"dummy", "-confy-help",
 	}
 
-	_, err := LoadCli[lotsOfArrays](DefaultCliDelimiter)
+	_, err := LoadCli[lotsOfArrays](CLIDelimiter)
 	if err == nil {
 		t.Fail()
 	}
@@ -140,7 +140,7 @@ func TestCliHelperMethod(t *testing.T) {
 		"Nested.NestedVal",
 	}
 
-	vals := GetGeneratedCliFlags[Small](DefaultCliDelimiter)
+	vals := GetGeneratedCliFlags[Small](CLIDelimiter)
 
 	if !reflect.DeepEqual(expectedContents, vals) {
 		t.Fatalf("expected %v got %v", expectedContents, vals)
@@ -159,7 +159,7 @@ func TestCliTransform(t *testing.T) {
 		"-COMPLEX_ARRAY", "text1,text2,text3", // Example for ComplexArray (implementsTextUnmarshaler)
 	}
 
-	dummyConfig, err := LoadCliWithTransform[testCliStruct](DefaultCliDelimiter, strings.ToUpper)
+	dummyConfig, err := LoadCliWithTransform[testCliStruct](CLIDelimiter, strings.ToUpper)
 	if err != nil {
 		t.Fatal(err)
 	}

entry.go

@@ -226,12 +226,12 @@ func Defaults(cliFlag, defaultPath string) OptionFunc {
 			errs = append(errs, err)
 		}
 
-		err = FromEnvs(DefaultENVDelimiter)(c)
+		err = FromEnvs(ENVDelimiter)(c)
 		if err != nil {
 			errs = append(errs, err)
 
 		}
-		err = FromCli(DefaultCliDelimiter)(c)
+		err = FromCli(CLIDelimiter)(c)
 		if err != nil {
 			errs = append(errs, err)
 
@@ -256,11 +256,11 @@ func DefaultsFromPath(path string) OptionFunc {
 		if err != nil {
 			errs = append(errs, err)
 		}
-		err = FromEnvs(DefaultENVDelimiter)(c)
+		err = FromEnvs(ENVDelimiter)(c)
 		if err != nil {
 			errs = append(errs, err)
 		}
-		err = FromCli(DefaultCliDelimiter)(c)
+		err = FromCli(CLIDelimiter)(c)
 		if err != nil {
 			errs = append(errs, err)
 		}

env_test.go

@@ -14,7 +14,7 @@ func TestEnvBasicTypes(t *testing.T) {
 	os.Setenv("b_bool", "true")
 	os.Setenv("thonku_complex_Mff", "toaster")
 
-	dummyConfig, err := LoadEnv[testStruct](DefaultENVDelimiter)
+	dummyConfig, err := LoadEnv[testStruct](ENVDelimiter)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -41,7 +41,7 @@ func TestEnvComplexTypes(t *testing.T) {
 	os.Setenv("basic_array", "item1,item2,item3")
 	os.Setenv("complex_array", "text1,text2,text3")
 
-	dummyConfig, err := LoadEnv[testCliStruct](DefaultENVDelimiter)
+	dummyConfig, err := LoadEnv[testCliStruct](ENVDelimiter)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -98,7 +98,7 @@ func TestEnvHelperMethod(t *testing.T) {
 		"Nested_NestedVal",
 	}
 
-	vals := GetGeneratedEnv[Small](DefaultENVDelimiter)
+	vals := GetGeneratedEnv[Small](ENVDelimiter)
 
 	if !reflect.DeepEqual(expectedContents, vals) {
 		t.Fatalf("expected %v got %v", expectedContents, vals)
@@ -114,7 +114,7 @@ func TestEnvTransform(t *testing.T) {
 	os.Setenv("BASIC_ARRAY", "item1,item2,item3")
 	os.Setenv("COMPLEX_ARRAY", "text1,text2,text3")
 
-	dummyConfig, err := LoadEnvWithTransform[testCliStruct](DefaultENVDelimiter, strings.ToUpper)
+	dummyConfig, err := LoadEnvWithTransform[testCliStruct](ENVDelimiter, strings.ToUpper)
 	if err != nil {
 		t.Fatal(err)
 	}

types.go

@@ -32,8 +32,10 @@ const (
 )
 
 const (
-	DefaultENVDelimiter = "_"
-	DefaultCliDelimiter = "."
+	// The default delimiter used for environment variable search
+	ENVDelimiter = "_"
+	// the default delimiter used for cli flag construction
+	CLIDelimiter = "."
 
 	LoggingDisabled = math.MaxInt
 )