Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc. metrics count issues #16

Open
jeanetteclark opened this issue Jul 22, 2024 · 0 comments
Open

misc. metrics count issues #16

jeanetteclark opened this issue Jul 22, 2024 · 0 comments

Comments

@jeanetteclark
Copy link
Collaborator

Carried over from issue #11 -

I found an issue where a bunch (500ish) rows had mostly missing values in the objects data frame, which caused an error when converting dateUploaded to a date object. For now I just filtered them out on

arcticreport/R/plot_cumulative_volume.R

Line 17 in cedd9f3
dplyr::filter(!is.na(.data$dateUploaded)) %>%
, but we should really dive in and find out where these rows originate and why the fields are missing:

Determine why fields are missing from a bunch of rows and fix the issue

Additionally, some of the tests I wrote with hard coded values for things like number of datasets in a particular month are failing. This means that at some point we calculated that there were say 100 datasets submitted between January 1 and February 1 of 2021, but for some reason now we calculate that 103 datasets were submitted then. We need to figure out what is causing our counts to (slightly) change. It might be related to the above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant